Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2004#discussion_r132318357
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/ProxyAuthenticator.java
 ---
    @@ -16,35 +16,28 @@
      */
     package org.apache.nifi.processors.standard.util;
     
    +import okhttp3.Authenticator;
    +import okhttp3.Credentials;
    +import okhttp3.Request;
    +import okhttp3.Response;
    +import okhttp3.Route;
    +
    +import javax.annotation.Nullable;
     import java.io.IOException;
    -import java.net.Proxy;
    -import java.util.HashMap;
    -import java.util.Map;
     
    -import com.burgstaller.okhttp.DispatchingAuthenticator;
    -import com.squareup.okhttp.Authenticator;
    -import com.squareup.okhttp.Credentials;
    -import com.squareup.okhttp.Request;
    -import com.squareup.okhttp.Response;
    +public class ProxyAuthenticator implements Authenticator {
    --- End diff --
    
    I was targeting 1.4.0
    
    I understand that it's a public class but I wouldn't consider it part of 
the public API. Looking at the items explicitly listed that fall under the 
public API, the closest one I see is "Any extension such as Processor, 
Controller Service, Reporting Task." I see it falling outside of that though 
since it's not a component itself. In what way do you see it falling under the 
items listed as our public API?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to