ASF GitHub Bot commented on NIFI-2162:

Github user JPercivall commented on a diff in the pull request:

    --- Diff: 
    @@ -16,35 +16,28 @@
     package org.apache.nifi.processors.standard.util;
    +import okhttp3.Authenticator;
    +import okhttp3.Credentials;
    +import okhttp3.Request;
    +import okhttp3.Response;
    +import okhttp3.Route;
    +import javax.annotation.Nullable;
     import java.io.IOException;
    -import java.net.Proxy;
    -import java.util.HashMap;
    -import java.util.Map;
    -import com.burgstaller.okhttp.DispatchingAuthenticator;
    -import com.squareup.okhttp.Authenticator;
    -import com.squareup.okhttp.Credentials;
    -import com.squareup.okhttp.Request;
    -import com.squareup.okhttp.Response;
    +public class ProxyAuthenticator implements Authenticator {
    --- End diff --
    I was targeting 1.4.0
    I understand that it's a public class but I wouldn't consider it part of 
the public API. Looking at the items explicitly listed that fall under the 
public API, the closest one I see is "Any extension such as Processor, 
Controller Service, Reporting Task." I see it falling outside of that though 
since it's not a component itself. In what way do you see it falling under the 
items listed as our public API?

> InvokeHttp's underlying library for Digest Auth uses the Android logger
> -----------------------------------------------------------------------
>                 Key: NIFI-2162
>                 URL: https://issues.apache.org/jira/browse/NIFI-2162
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Joseph Percivall
>            Assignee: Joseph Percivall
> A user emailed the User mailing list with an issue that InvokeHttp was 
> failing due to not being able to find "android/util/Log"[1]. InvokeHttp uses 
> OkHttp and the library they recommend for digest authentication is 
> okhttp-digest[2]. Currently okhttp-digest assumes it's running on an Android 
> device and has access to the Android logger (OkHttp does not assume it's on 
> an Android device). 
> I raised an issue about it on the project's github page[3] and the creator 
> said he "Will change this soonish."
> Once that is addressed, InvokeHttp will need to update the versions of OkHttp 
> and okhttp-digest. 
> [1] http://mail-archives.apache.org/mod_mbox/nifi-users/201606.mbox/browser
> [2] https://github.com/square/okhttp/issues/205
> [3] https://github.com/rburgst/okhttp-digest/issues/13

This message was sent by Atlassian JIRA

Reply via email to