[ https://issues.apache.org/jira/browse/NIFI-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122517#comment-16122517 ]
ASF GitHub Bot commented on NIFI-4187: -------------------------------------- GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/2073 NIFI-4187 Resolved issue where restart failed due to missing sensitiv… …e key file. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alopresto/nifi NIFI-4187 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2073.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2073 ---- commit 7dc0bd2084820a9f924a0593f2e938efb1a0ceed Author: Andy LoPresto <alopre...@apache.org> Date: 2017-08-10T23:16:29Z NIFI-4187 Resolved issue where restart failed due to missing sensitive key file. ---- > If NiFi process is killed, bootstrap auto-restart hangs on missing sensitive > key file > ------------------------------------------------------------------------------------- > > Key: NIFI-4187 > URL: https://issues.apache.org/jira/browse/NIFI-4187 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework > Affects Versions: 1.3.0 > Reporter: Andy LoPresto > Priority: Critical > Labels: bootstrap, encryption > > If the NiFi process is killed and {{autoRestart}} is enabled in the bootstrap > process ({{RunNiFi.java}}) (enabled by default except when in {{run}} mode) > and the instance is using encrypted configuration files, the > {{sensitive.key}} file which contains the master encryption key is no longer > available when restart occurs. This results in the application exiting. > To resolve this, the logic to prepare and generate the sensitive key file > should be extracted to a method and invoked during initial start *and* during > the auto-restart loop at > https://github.com/apache/nifi/blob/master/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java#L1159 > . -- This message was sent by Atlassian JIRA (v6.4.14#64029)