[
https://issues.apache.org/jira/browse/NIFI-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124432#comment-16124432
]
ASF GitHub Bot commented on NIFI-4286:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2078
NIFI-4286: Fix NPE in GenerateTableFetch when Partition Size = 0
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4286
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2078.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2078
----
commit 6910de784f1254a2bab5960963716d8758f82b75
Author: Matt Burgess <[email protected]>
Date: 2017-08-12T03:38:17Z
NIFI-4286: Fix NPE in GenerateTableFetch when Partition Size = 0
----
> GenerateTableFetch with Partition Size of 0 produces NPE
> --------------------------------------------------------
>
> Key: NIFI-4286
> URL: https://issues.apache.org/jira/browse/NIFI-4286
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Bryan Bende
> Assignee: Matt Burgess
> Priority: Minor
>
> The description of partition size says "A value of zero indicates that a
> single FlowFile is to be generated whose SQL statement will fetch all rows in
> table".
> If you set the partition size to 0 the processor will get an NPE at these two
> lines:
> long limit = partitionSize == 0 ? null : partitionSize;
> long offset = partitionSize == 0 ? null : i * partitionSize;
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
