Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2056#discussion_r133019004
  
    --- Diff: 
nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/bin/BinFiles.java
 ---
    @@ -94,6 +96,16 @@
                 .addValidator(StandardValidators.createTimePeriodValidator(1, 
TimeUnit.SECONDS, Integer.MAX_VALUE, TimeUnit.SECONDS))
                 .build();
     
    +    public static final PropertyDescriptor ADD_MERGED_UUID = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    I talked this over with @markap14 as well, it seems like just adding an 
attribute here is a better user experience than adding another property to 
offer a choice. I presume it was to offer the current behavior as well, which 
normally is a good thing so as not to upset existing flows, but I think in this 
case you could just add it (and document it). New attributes on split flowfiles 
might affect memory, but for merged flow files it should not be an issue. What 
do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to