[
https://issues.apache.org/jira/browse/NIFI-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126952#comment-16126952
]
ASF GitHub Bot commented on NIFI-4062:
--------------------------------------
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2080#discussion_r133138260
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java
---
@@ -272,10 +315,9 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
public void process(final InputStream rawIn) throws
IOException {
try (final InputStream in = new
BufferedInputStream(rawIn)) {
XQueryEvaluator qe = slashExpression.load();
- qe.setSource(new SAXSource(new InputSource(in)));
- DocumentBuilderFactory dfactory =
DocumentBuilderFactory.newInstance();
- dfactory.setNamespaceAware(true);
- Document dom =
dfactory.newDocumentBuilder().newDocument();
+ final Document document=docBuilder.parse(in);
+ qe.setSource(new DOMSource(document));
+ Document dom = docBuilder.newDocument();
--- End diff --
Is there any performance impact by changing from SAX to DOM to evaluate a
large XML document?
> Provide an option to disable DTD validation for EvaluateXPath and
> EvaluateXQuery
> --------------------------------------------------------------------------------
>
> Key: NIFI-4062
> URL: https://issues.apache.org/jira/browse/NIFI-4062
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.0.0
> Reporter: Koji Kawamura
> Assignee: Arun Manivannan
> Labels: beginner
>
> Currently EvaluateXPath and EvaluateXQuery can fail if the source document
> has DOCTYPE definition in it, especially using external DTD. It would be
> useful if these processor provides a property to disable DTD validation when
> evaluate XPath or XQuery.
> References:
> https://community.hortonworks.com/questions/107121/does-evaluatexpath-support-doctype.html
> https://stackoverflow.com/questions/243728/how-to-disable-dtd-at-runtime-in-javas-xpath
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
