GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2086
NIFI-4208: Fixed bug in SchemaRepositoryRecordSerde that would returnâ¦
⦠null from deserializeEdit if there was no data; the interface documents
that null cannot be returned from this method, as it is called only when data
is expected to exist. As a result, if there is no data, we should throw
EOFException instead, and the write-ahead log will handle that appropriately
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4208
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2086.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2086
----
commit a8cf805381489b35a56062a0cdf52eea6fa4fb76
Author: Mark Payne <[email protected]>
Date: 2017-08-15T14:39:46Z
NIFI-4208: Fixed bug in SchemaRepositoryRecordSerde that would return null
from deserializeEdit if there was no data; the interface documents that null
cannot be returned from this method, as it is called only when data is expected
to exist. As a result, if there is no data, we should throw EOFException
instead, and the write-ahead log will handle that appropriately
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
