[ 
https://issues.apache.org/jira/browse/NIFI-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128865#comment-16128865
 ] 

ASF GitHub Bot commented on NIFI-4062:
--------------------------------------

Github user arunma commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2080#discussion_r133464300
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXPath.java
 ---
    @@ -219,6 +234,25 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
             }
     
             final ComponentLog logger = getLogger();
    +        final XMLReader xmlReader;
    +
    +        try {
    +            xmlReader = XMLReaderFactory.createXMLReader();
    +        } catch (SAXException e) {
    +            logger.error("Error while constructing XMLReader {}", new 
Object[]{e});
    +            session.transfer(flowFiles, REL_FAILURE);
    --- End diff --
    
    Yikes. My bad ! Fixed it. Both throw ProcessException.


> Provide an option to disable DTD validation for EvaluateXPath and 
> EvaluateXQuery
> --------------------------------------------------------------------------------
>
>                 Key: NIFI-4062
>                 URL: https://issues.apache.org/jira/browse/NIFI-4062
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.0.0
>            Reporter: Koji Kawamura
>            Assignee: Arun Manivannan
>              Labels: beginner
>
> Currently EvaluateXPath and EvaluateXQuery can fail if the source document 
> has DOCTYPE definition in it, especially using external DTD. It would be 
> useful if these processor provides a property to disable DTD validation when 
> evaluate XPath or XQuery.
> References:
> https://community.hortonworks.com/questions/107121/does-evaluatexpath-support-doctype.html
> https://stackoverflow.com/questions/243728/how-to-disable-dtd-at-runtime-in-javas-xpath



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to