Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1877
@ijokarumawak it does look good now. Unfortunately, though, it looks like
it needs to be rebased. It looks like this is a rather large PR, though, that
touches a lot of different points. And it looks like there are several new
processors, controller services, etc. that have been merged to master since the
PR was created. I wonder if it may make sense, instead of changing
RecordReaderFactory to take `Map<String, String>` variables instead of
`FlowFIle flowFile`, I wonder if it makes sense to add both methods to the
interface, and then have a default method in the interface, such as:
```
default RecordReader createRecordReader(FlowFile flowFile, InputStream in,
ComponentLog logger) throws MalformedRecordException, IOException,
SchemaNotFoundException {
return createRecordReader(flowFile == null ? Collections.emptyMap()
: flowFile.getAttributes(), in, logger);
}
RecordReader createRecordReader(Map<String, String> variables,
InputStream in, ComponentLog logger) throws MalformedRecordException,
IOException, SchemaNotFoundException;
```
Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
