[
https://issues.apache.org/jira/browse/NIFI-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131935#comment-16131935
]
ASF GitHub Bot commented on NIFI-1670:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2097
NIFI-1670 - typos/details in EL doc
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-1670
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2097.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2097
----
commit 900347ff6a58921996668d913c7cbbc56bebfa74
Author: Pierre Villard <[email protected]>
Date: 2017-08-16T15:49:38Z
NIFI-1670 - typos/details in EL doc
----
> Expression Language documentation should be clarified for isEmpty and
> allAttributes
> -----------------------------------------------------------------------------------
>
> Key: NIFI-1670
> URL: https://issues.apache.org/jira/browse/NIFI-1670
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation & Website
> Affects Versions: 0.6.0
> Reporter: Andy LoPresto
> Priority: Minor
> Labels: documentation, expression-language
>
> The documentation for {{isEmpty}} and {{allAttributes}} should be reviewed
> for correctness and clarity as pointed out by a member of the mailing list.
> From the mailing list:
> From: Paul Nahay <[email protected]>
> Subject: Errors in your Documentation
> Date: March 22, 2016 at 5:52:10 AM PDT
> To: [email protected]
> Cc: Jonathan Wood <[email protected]>
> Reply-To: [email protected]
> Reply-To: Paul Nahay <[email protected]>
> I'm looking at:
> https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html
> isEmpty
> Description: The isEmpty function returns true if the Subject is null or
> contains only white-space (new line, carriage return, space, tab), false
> otherwise.
> This logically implies that isEmpty returns FALSE if the Subject contains NO
> CHARACTERS AT ALL (not even white-space). This makes no sense at all.
> allAttributes
> Description: Checks to see if any of the given attributes, match the given
> condition.
> Hopefully you actually mean "all", not "any".
> What's funny here is that THESE TWO functions were the ones I initially
> needed, and your documentation has errors for BOTH of them. I'll expect then
> to find more errors in your documentation, and will report them to you as I
> find them.
> Feedback confirming the errors will be appreciated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
