[ 
https://issues.apache.org/jira/browse/NIFIREG-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136860#comment-16136860
 ] 

ASF GitHub Bot commented on NIFIREG-7:
--------------------------------------

Github user kevdoran commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/5#discussion_r134497934
  
    --- Diff: 
nifi-registry-provider-api/src/main/java/org/apache/nifi/registry/flow/FlowProvider.java
 ---
    @@ -0,0 +1,68 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.registry.flow;
    +
    +import org.apache.nifi.registry.provider.Provider;
    +
    +/**
    + * A service that can store and retrieve versioned flow snapshots.
    + *
    + * NOTE: Although this interface is intended to be an extension point, it 
is not yet considered stable and thus may
    + * change across releases until the registry matures.
    + */
    +public interface FlowProvider extends Provider {
    --- End diff --
    
    @bbende, thanks for the reply. The example higher-level logic provided by 
the service layer makes sense to me. The type of search I have in mind for the 
not-to-distant-future is adding url-parameter filters to the rest endpoints 
that list resources, e.g.:
    
    `/buckets?name=production`
    
    I agree that search is a use case that would need further thought, and I 
see there are multiple ways that could be added given the foundation created in 
this PR. Thanks!


> Define Flow Persistence Provider Interface
> ------------------------------------------
>
>                 Key: NIFIREG-7
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-7
>             Project: NiFi Registry
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>
> The Flow Persistence Provider will be the interface that the REST/service 
> layer uses to perform CRUD operations on versioned flows. The implementation 
> used by the application should be configurable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to