GitHub user YolandaMDavis opened a pull request:
https://github.com/apache/nifi/pull/2107
NIFI-4310 - added changes to support detection of reporting tasks andâ¦
⦠controller services during isEmpty flow check. Added testing scenarios
Recommend the following tests scenarios are included:
- Confirm cluster starts after flow election with empty flows on all nodes
- Confirm start after election initiated for cluster having all but one
node containing empty flows (one remaining node contains flow populated with
root process group)
- Confirm start after election initiated for cluster containing 1/2 nodes
with empty flows (remaining halves would contain flows with only controller
services).
- Confirm start after election initiated for cluster containing 1/2 nodes
with empty flows (remaining halves would contain flows with only reporting
tasks).
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YolandaMDavis/nifi NIFI-4310
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2107
----
commit 028e381e281d982cc6683c9a0949a3dc820b55d7
Author: Yolanda M. Davis <[email protected]>
Date: 2017-08-23T05:53:49Z
NIFI-4310 - added changes to support detection of reporting tasks and
controller services during isEmpty flow check. Added testing scenarios
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
