[ 
https://issues.apache.org/jira/browse/NIFIREG-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141976#comment-16141976
 ] 

ASF GitHub Bot commented on NIFIREG-11:
---------------------------------------

Github user bbende commented on the issue:

    https://github.com/apache/nifi-registry/pull/6
  
    @kevdoran thanks for reviewing!
    
    I pushed up another commit that changes the equals method you mentioned... 
I agree that as long as flow id's are globally unique, then we only need to use 
flow id + version for the hash/equals of the snapshot method.
    
    Regarding using the metadata objects in the REST layer... I think we should 
still leave the REST end-points using the original data model, and the service 
layer will translate from the provider API to the regular data model.
    
    I also added a "BucketItemType" in BucketItem so that if the front-end was 
looking at bucket item they could easily look at field to determine the type.
    
    If you are good with those changes then I am going to merge this in. Thanks!


> Refactor Domain Model
> ---------------------
>
>                 Key: NIFIREG-11
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-11
>             Project: NiFi Registry
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>             Fix For: 0.0.1
>
>
> We should create a separate object model for the provider API so that those 
> objects can be decoupled from the standard data model.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to