Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1975
@bbende Thanks for reviewing this.
This PR is now rebased with the latest master. The last commit includes
following changes.
The failing TestFTP.basicFileList has been added after I worked on this PR.
It uses FakeFTPServer, which provides timestamp precision in minutes. Then this
PR adds time precision auto detection by default. The file which was expected
to be picked was not picked because it hadn't passed the required amount of lag
time for minute precision. The test has been updated to use millisecond
precision explicitly and also thread sleep has been added. The same error was
confirmed in my environment, but it's been addressed.
Similarly, I found that TestAbstractListProcessor tests can fail due to
luck of time unit setting, when generated timestamp does not have the desired
time unit value, e.g. generated '10:51:00' where second precision is tested.
This has been addressed, too.
Finally, the reason for changing junit dependency is
ListProcessorTestWatcher. It resides in `nifi-processor-utils` and is used by
the project and also `nifi-standard-processors` project. In order to share
ListProcessorTestWatcher via nifi-processor-utils, I changed junit scope to
'compile' because it needs to be accessible from the 'main' source, not by
'test' source. But 'provided' is more reasonable in this case, so I've updated
it to 'provided'. Without having a mechanism like ListProcessorTestWatcher,
debugging test failures will be very difficult, especially if it happens
occasionally in a remote environment such as Travis CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
