[
https://issues.apache.org/jira/browse/NIFI-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147885#comment-16147885
]
ASF GitHub Bot commented on NIFI-4334:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2117
NIFI-4334: Added Apache Commons Net to scripting NAR
I couldn't find a service that would work for unit testing, but integration
tests could be added to test specific clients.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4334
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2117
----
commit 082743bc341533c1633a69b814f0ed3851603408
Author: Matthew Burgess <[email protected]>
Date: 2017-08-30T19:25:56Z
NIFI-4334: Added Apache Commons Net to scripting NAR
----
> Add Apache Commons Net to scripting NAR
> ---------------------------------------
>
> Key: NIFI-4334
> URL: https://issues.apache.org/jira/browse/NIFI-4334
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
>
> The scripting NAR, which includes scripting processors, reporting tasks, and
> controller services, is often used to prototype custom connections to
> external entities when built-in NiFi support is not yet present. The Apache
> Commons Net library has a number of clients and utilities that would make
> such connections easier. At only half an MB in size, it would be nice to add
> this as a dependency to the scripting NAR such that any scripted solution
> could leverage these classes. One example could be to prototype an FTPS
> client to use until NIFI-2278 is implemented.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
