[
https://issues.apache.org/jira/browse/NIFI-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149343#comment-16149343
]
ASF GitHub Bot commented on NIFI-4339:
--------------------------------------
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi/pull/2118
NIFI-4339: Fix NPE in ExtractEmailHeaders
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi NIFI-4339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2118
----
commit ec431048fb80d1150559850af79f6d6ef47e74a8
Author: Kevin Doran <[email protected]>
Date: 2017-08-31T15:58:16Z
NIFI-4339: Fix NPE in ExtractEmailHeaders
----
> Possible NPE in ExtractEmailHeaders if no recipients exist
> ----------------------------------------------------------
>
> Key: NIFI-4339
> URL: https://issues.apache.org/jira/browse/NIFI-4339
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Kevin Doran
> Assignee: Kevin Doran
> Priority: Minor
> Fix For: 1.4.0
>
>
> A user uncovered a *NullPointerException* in the ExtractEmailHeaders
> processor and [asked about it on
> StackOverflow|https://stackoverflow.com/questions/45927852/nifi-email-consumeimap-filter-by-subject-from-to-and-date].
> Here is the summary: If the TO, CC, and BCC are not present in the email
> message, a call to {{javax.mail.internet.MimeMessage getAllRecipients()}}
> will return {{null}}.
> While this is a rare case, the reporter has a use case in which an email
> account is sending automated emails to the same address as the source, and
> whatever email program is being used appears to not set any address fields in
> this case:
> {quote}It is an auto email from client to their own inbox and does not have
> "to", "cc"and "bcc"{quote}
> The {{javax.mail.Message getAllRecipients()}} method, which is called from
> {{javax.mail.internet.MimeMessage getAllRecipients()}}, will return null in
> this case, as is documented and apparent from the source code:
> {code:java}
> /**
> * Get all the recipient addresses for the message.
> * The default implementation extracts the TO, CC, and BCC
> * recipients using the <code>getRecipients</code> method. <p>
> *
> * This method returns <code>null</code> if none of the recipient
> * headers are present in this message. It may Return an empty array
> * if any recipient header is present, but contains no addresses.
> *
> * @return array of Address objects
> * @exception MessagingException
> */
> public Address[] getAllRecipients() throws MessagingException {
> Address[] to = getRecipients(RecipientType.TO);
> Address[] cc = getRecipients(RecipientType.CC);
> Address[] bcc = getRecipients(RecipientType.BCC);
> if (cc == null && bcc == null)
> return to; // a common case
>
> // ...
> {code}
> Here is a stack trace for the NPE:
> {noformat}
> 2017-08-30 16:36:05,930 ERROR [Timer-Driven Process Thread-8]
> o.a.n.p.email.ExtractEmailHeaders ExtractEmailHeaders [...] Could not parse
> the flowfile StandardFlowFileRecord [...] as an email, treating as failure:
> java.lang.NullPointerException: null
> at java.lang.reflect.Array.getLength(Native Method)
> at
> org.apache.nifi.processors.email.ExtractEmailHeaders$1.process(ExtractEmailHeaders.java:171)
>
> at
> org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2177)
>
> at
> org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:2147)
>
> at
> org.apache.nifi.processors.email.ExtractEmailHeaders.onTrigger(ExtractEmailHeaders.java:146)
>
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
>
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1118)
>
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147)
>
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
>
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:132)
>
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> {noformat}
> The NPE occurs as ExtractEmailHeaders:L171:
> {code:java}
> if (Array.getLength(originalMessage.getAllRecipients()) > 0) {
> {code}
> {{Array.getLength(Array array)}} expects a non-null argument, but
> {{originalMessage.getAllRecipients()}} is returning {{null}}.
> One proposed solution is to check if {{originalMessage.getAllRecipients()}}
> is {{null}}, and if so, treat it as an empty array. That is, the condition
> would be:
> {code:java}
> Address[] allRecipients = originalMessage.getAllRecipients();
> if (allRecipients != null && Array.getLength(allRecipients) > 0) {
> {code}
> A test case for ExtractEmailHeaders that reproduces this NPE should also be
> added.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
