[
https://issues.apache.org/jira/browse/NIFI-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158906#comment-16158906
]
ASF GitHub Bot commented on NIFI-4361:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2133#discussion_r137837796
--- Diff:
nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java
---
@@ -474,8 +474,15 @@ private void recoverFromEdits(final Map<Object, T>
modifiableRecordMap, final Lo
subsequentTransactionId =
nextPartition.getNextRecoverableTransactionId();
} catch (final IOException e) {
logger.error("{} unexpectedly found End-of-File when
reading from {} for Transaction ID {}; "
- + "assuming crash and ignoring this transaction",
+ + "attempting to get the next recoverable
transaction ID",
--- End diff --
@gresockj thanks for the contribution! The only concern that I have here is
that this update assumes that we will never get more than 1 IOException in a
row... I think we need to continue looping until we've run out of 'recovery
files' for the partition.
> Server fails to start during recovery upon full disk
> ----------------------------------------------------
>
> Key: NIFI-4361
> URL: https://issues.apache.org/jira/browse/NIFI-4361
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.1.0, 1.2.0, 1.3.0
> Reporter: Joseph Gresock
> Assignee: Joseph Gresock
> Fix For: 1.4.0
>
>
> Our disk filled up -- we then freed up some space and restarted, but the
> server failed to start up due to:
> ERROR [main] o.a.nifi.controller.StandardFlowService Failed to load flow from
> cluster due to: org.apache.nifi.cluster.ConnectionException: Failed to
> connect node to cluster due to: java.lang.IllegalStateException: Signaled end
> to recovery, but there are more recovery files for Partition in directory
> /data/nifi/flowfile_repository/partition-8
> at
> org.wali.MinimalLockingWriteAheadLog$Partition.endRecovery(MinimalLockingWriteAheadLog.java:1047)
> ~[nifi-write-ahead-log-1.1.0.jar:1.1.0]
> at
> org.wali.MinimalLockingWriteAheadLog.recoverFromEdits(MinimalLockingWriteAheadLog.java:487)
> ~[nifi-write-ahead-log-1.1.0.jar:1.1.0]
> at
> org.wali.MinimalLockingWriteAheadLog.recoverRecords(MinimalLockingWriteAheadLog.java:301)
> ~[nifi-write-ahead-log-1.1.0.jar:1.1.0]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
