[GitHub] nifi-minifi-cpp pull request #134: MINIFI-339: Add C2 base allowing for 1 pr...

[benqiu2016]

Github user benqiu2016 commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137857666
  
    --- Diff: libminifi/include/ResourceClaim.h ---
    @@ -55,23 +58,20 @@ class ResourceClaim : public 
std::enable_shared_from_this<ResourceClaim> {
     
       ResourceClaim(const std::string path, 
std::shared_ptr<core::StreamManager<ResourceClaim>> claim_manager, bool deleted 
= false);
       // Destructor
    -  virtual ~ResourceClaim() {
    +  ~ResourceClaim() {
    --- End diff --
    
    why remove the virtual?


---