Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/2136
  
    Thanks @yuri1969 . @jtstorck I found other batch files already use 
`JAVA_ARGS` such as `run-nifi.bat`, but those usages are enclosed within the 
batch file itself.
    
    So, I think we can still establish parity between .sh and .bat scripts when 
those existing bat scripts exposes the config to user land, by using  
`JAVA_OPTS`. The reason I care about naming here is, because the name is 
exposed to user code base.
    
    I've created a commit based on yours.
    
https://github.com/ijokarumawak/nifi/commit/8fca2515d3ca422e6669f7e8a6d111eb0a218205
    
    If it looks good, please cherry-pick it, or just updating your PR is fine 
for me, too.
    Other part, I'm +1 for this PR, thanks!


---

Reply via email to