[ 
https://issues.apache.org/jira/browse/NIFIREG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173817#comment-16173817
 ] 

ASF GitHub Bot commented on NIFIREG-18:
---------------------------------------

Github user kevdoran commented on the issue:

    https://github.com/apache/nifi-registry/pull/10
  
    @bbende I reviewed your two new commits. Both look good to me. Thanks for 
making those fixes.
    
    -Pcontrib-check is complaining about some whitespace on an empty line:
    
    ```
    [INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @ 
nifi-registry-web-api ---
    [WARNING] 
src/main/java/org/apache/nifi/registry/NiFiRegistryApiApplication.java[44] 
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
    ```
    
    Other than that, LGTM.


> Refactor MetadataProvider to use an embedded database
> -----------------------------------------------------
>
>                 Key: NIFIREG-18
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-18
>             Project: NiFi Registry
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>
> We need to leverage transactions when persisting data to avoid inconsistent 
> states. Currently the MetadataProvider is based on an XML file which doesn't 
> offer much way to rollback an operation. We should switch to using an 
> embedded database.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to