[
https://issues.apache.org/jira/browse/NIFI-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175716#comment-16175716
]
ASF GitHub Bot commented on NIFI-4395:
--------------------------------------
Github user yjhyjhyjh0 commented on the issue:
https://github.com/apache/nifi/pull/2166
Thanks for the detail comment and suggestion.
That helps me a lot.
Some fix by suggestion like.
1 - put back StringmaxValueColumnNames to GenerateTableFetch to avoid NPE
unit test fail.
(Originally forget to include this line)
2 - move re-cache method, calling super.setup(), before the getColumnType
to provide more
readable code.
3 - Remove ternary operator because evaluateAttributeExpressions already
can handle null flowfile.
Thanks
> GenerateTableFetch can't fetch column type by state after instance reboot
> -------------------------------------------------------------------------
>
> Key: NIFI-4395
> URL: https://issues.apache.org/jira/browse/NIFI-4395
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Deon Huang
> Assignee: Deon Huang
> Fix For: 1.4.0
>
> Attachments: GenerateTableFetch_Exception.png
>
>
> The problem can easily be reproduce.
> Once GenerateTableFetch store state and encounter NiFi instance reboot.
> (Dynamic naming table by expression language)
> The exception will occur.
> The error in source code is list below.
> ```
> if (type == null) {
> // This shouldn't happen as we are populating columnTypeMap when the
> processor is scheduled or when the first maximum is observed
> throw new IllegalArgumentException("No column type found for: " +
> colName);
> }
> ```
> When this situation happened. The FlowFile will also be grab and can't
> release or observed.
> Processor can't grab existing column type from *columnTypeMap* through
> instance reboot.
> Hence will inevidible get this exception, rollback FlowFile and never success.
> QueryDatabaseTable processor will not encounter this exception due to it
> setup(context) every time,
> While GenerateTableFetch will not pass the condition and thus try to fetch
> column type from 0 length columnTypeMap.
> ---
> if (!isDynamicTableName && !isDynamicMaxValues) {
> super.setup(context);
> }
> ---
> I can take the issue if it is recognize as bug.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
