[
https://issues.apache.org/jira/browse/NIFI-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180104#comment-16180104
]
ASF GitHub Bot commented on NIFI-4410:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2175
NIFI-4410: Improved error handling/logging in PutElasticsearchHttp
processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4410
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2175.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2175
----
commit e21bf18d3683a37b78b3da4279043b1be6498ca9
Author: Matthew Burgess <[email protected]>
Date: 2017-09-26T02:25:29Z
NIFI-4410: Improved error handling/logging in PutElasticsearchHttp
processors
----
> PutElasticsearchHttp needs better error handling and logging
> ------------------------------------------------------------
>
> Key: NIFI-4410
> URL: https://issues.apache.org/jira/browse/NIFI-4410
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Joseph Witt
> Assignee: Matt Burgess
>
> https://github.com/apache/nifi/blob/6b5015e39b4233cf230151fb45bebcb21df03730/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java#L364-L366
> If it cannot extract the reason text it provides a very generic error and
> there is nothing else logged. You get no context as to what went wrong and
> further the condition doesn't cause yielding or anything so there is just a
> massive flood of errors in logs that dont' advise the user of the problem.
> We need to make sure the information can be made available to help
> troubleshoot and we need to cause yielding so that such cases do not cause
> continuous floods of errors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
