[
https://issues.apache.org/jira/browse/NIFI-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180819#comment-16180819
]
ASF GitHub Bot commented on NIFI-4424:
--------------------------------------
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2176
@joewitt Apparently, RAT is complaining about some web files, so it is
definitely not my change:
```
*****************************************************
Summary
-------
Generated at: 2017-09-26T15:51:59+02:00
Notes: 5
Binaries: 24
Archives: 0
Standards: 288
Apache Licensed: 277
Generated Documents: 0
JavaDocs are generated and so license header is optional
Generated files do not required license headers
11 Unknown Licenses
*******************************
Unapproved licenses:
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/frontend/package.json
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/fonts/flowfont/flowfont.css
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/fonts/flowfont/flowfont.svg
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/codemirror/addon/fold/foldgutter.css
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/codemirror/addon/hint/show-hint.css
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/codemirror/addon/lint/json-lint.js
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/codemirror/addon/lint/lint.css
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/codemirror/addon/lint/lint.js
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/codemirror/lib/codemirror-compressed.js
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/codemirror/lib/codemirror.css
/Users/FOOBAR/Projects/OpenSource/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/jquery.base64.js
*******************************
```
If that helps the investigation, I can send a more detailed extract of the
build in private.
> org.apache.nifi.NiFi does not allow programmatic access to the NiFi engine
> --------------------------------------------------------------------------
>
> Key: NIFI-4424
> URL: https://issues.apache.org/jira/browse/NIFI-4424
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.3.0
> Reporter: Peter Horvath
>
> Class {{org.apache.nifi.NiFi}} was not designed with extensibility or
> programmatic access in mind.
> This class is the entry point of the engine, however, the current
> implementation does not allow
> a potential caller (e.g. an integration test harness) to bootstrap the engine
> and then shut it down properly:
> The main method {{org.apache.nifi.NiFi#main}} simply logs any exception,
> which is fine
> when started from the command line, however prevents programmatic usage and
> detecting error conditions (Exceptions) that would be essential to
> programatically access
> it from an integration test.
> The constructor {{org.apache.nifi.NiFi#NiFi}} registers an
> {{UncaughtExceptionHandler}},
> a JVM {{Shutdown Hook}} and changes logging framework settings.
> *Please change this behaviour:*
> Expose *two* methods, one of which accepts the command line argument one
> would pass
> to the NiFi process and another one, which allows the NiFiProperties object
> to be passed.
> This method should return the {{NiFi}} object instance for further
> programmatic access.
> The logic used to register {{UncaughtExceptionHandler}}, a JVM Shutdown Hook
> and
> changing logging framework settings should be extracted to a {{protected}}
> *instance*
> method so that a client can override their behaviour with a NO-OP.
> *Please note these changes are baby-steps towards the implementation of a
> NiFi integration test harness.*
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
