GitHub user gglanzani opened a pull request:
https://github.com/apache/nifi/pull/2186
[NIFI-4443] Increase StoreInKiteDataset flexibility
* The configuration property CONF_XML_FILE now support Expression
Language and reuse a Hadoop validator;
* The ADDITIONAL_CLASSPATH_RESOURCES property has been added, so that
things such as writing to Azure Blob Storage should become possible.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Yes. The Jira also mention Kerberos support. I am not feeling so
adventurous however (I'm a Python programmer). I can update the Jira and split
it, as I believe there is still value in this PR.
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
Note: `nifi-scripting-processors` is giving a, to me, completely unrelated
error to the proposed changes
```java
java.lang.ClassCastException: Cannot cast
jdk.nashorn.internal.objects.NativeArray to java.util.Collection
```
- [x] Have you written or updated unit tests to verify your changes?
I had to put in a Dataset creation in the test because otherwise I couldn't
use `runner.assertValid()`. If there is a simpler way to do this, please let me
know and I'll update accordingly.
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gglanzani/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2186
----
commit 6ab60ee2f14700fb3e8dd2849bef4391f536fca8
Author: Giovanni Lanzani <[email protected]>
Date: 2017-09-29T21:21:03Z
[NIFI-4443] Increase StoreInKiteDataset flexibility
* The configuration property CONF_XML_FILE now support Expression
Language and reuse a Hadoop validator;
* The ADDITIONAL_CLASSPATH_RESOURCES property has been added, so that
things such as writing to Azure Blob Storage should become possible.
----
---
