Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/14#discussion_r142465687
  
    --- Diff: nifi-registry-security/pom.xml ---
    @@ -51,11 +67,25 @@
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-checkstyle-plugin</artifactId>
                     <configuration>
    -                    <excludes>**/user/generated/*.java</excludes>
    +                    
<excludes>**/authorization/file/generated/*.java,**/authorization/file/tenants/generated/*.java</excludes>
                     </configuration>
                 </plugin>
             </plugins>
         </build>
    +
    +    <dependencyManagement>
    +        <dependencies>
    +            <!-- This is here because Spring Security 4.2.3.RELEASE builds 
against Spring Framwork 4.3.9.RELEASE -->
    +            <dependency>
    +                <groupId>org.springframework</groupId>
    +                <artifactId>spring-framework-bom</artifactId>
    --- End diff --
    
    What do you think about changing this and the spring-security-core 
dependency below to be:
    ```
    <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-security</artifactId>
        <version>${spring.boot.version}</version>
    </dependency>
    ```
    
    Just seeing if we can make it easier to keep a consistent version across 
all the places where spring-boot is referenced.


---

Reply via email to