[ 
https://issues.apache.org/jira/browse/NIFI-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191917#comment-16191917
 ] 

ASF GitHub Bot commented on NIFI-4346:
--------------------------------------

Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2125#discussion_r142770600
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientService.java
 ---
    @@ -88,16 +88,16 @@
     
         static final long TICKET_RENEWAL_PERIOD = 60000;
     
    -    private volatile Connection connection;
    +    protected volatile Connection connection;
         private volatile UserGroupInformation ugi;
         private volatile KerberosTicketRenewer renewer;
     
    -    private List<PropertyDescriptor> properties;
    -    private KerberosProperties kerberosProperties;
    +    protected List<PropertyDescriptor> properties;
    +    protected KerberosProperties kerberosProperties;
         private volatile File kerberosConfigFile = null;
     
         // Holder of cached Configuration information so validation does not 
reload the same config over and over
    -    private final AtomicReference<ValidationResources> 
validationResourceHolder = new AtomicReference<>();
    +    protected final AtomicReference<ValidationResources> 
validationResourceHolder = new AtomicReference<>();
    --- End diff --
    
    Can we leave as private? don't see anything referencing it.


> Add a lookup service that uses HBase
> ------------------------------------
>
>                 Key: NIFI-4346
>                 URL: https://issues.apache.org/jira/browse/NIFI-4346
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Mike Thomsen
>            Priority: Minor
>
> A LookupService based on HBase should be able to handle at least two 
> scenarios:
> 1. Pull a single cell and return it as a string.
> 2. Pull multiple cells and return them as a Record that can be merged into 
> another record.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to