[ 
https://issues.apache.org/jira/browse/NIFI-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193659#comment-16193659
 ] 

ASF GitHub Bot commented on NIFI-4371:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2138#discussion_r143055024
  
    --- Diff: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java
 ---
    @@ -290,6 +292,9 @@ public void process(final OutputStream out) throws 
IOException {
                                 }
                             }
     
    +                        // set query timeout
    +                        st.setQueryTimeout(queryTimeout);
    --- End diff --
    
    Nothing to be done here necessarily, but just wanted to mention that the 
success of this method is dependent on the customValidate() preventing the 
processor from running if the Hive JDBC driver does not support setQueryTimeout.


> Add support for query timeout in Hive processors
> ------------------------------------------------
>
>                 Key: NIFI-4371
>                 URL: https://issues.apache.org/jira/browse/NIFI-4371
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>         Attachments: Screen Shot 2017-09-09 at 4.31.21 PM.png, Screen Shot 
> 2017-09-09 at 6.38.51 PM.png, Screen Shot 2017-09-09 at 6.40.48 PM.png
>
>
> With HIVE-4924 it is possible to set a query timeout when executing a query 
> against Hive (starting with Hive 2.1). Right now, NiFi is built using Hive 
> 1.2.1 and this feature is not available by default (the method is not 
> implemented in the driver). However, if building NiFi with specific profiles 
> this feature can be used.
> The objective is to expose the query timeout parameter in the processor and 
> enable expression language. If the version of the driver is not implementing 
> the query timeout the processor will be in invalid state (unless expression 
> language is used, and in this case, the flow file will be routed to the 
> failure relationship).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to