Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2162#discussion_r143278853
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java
 ---
    @@ -155,10 +155,22 @@
                 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor SQL_QUERY = new 
PropertyDescriptor.Builder()
    +            .name("db-fetch-sql-query")
    +            .displayName("Arbitrary Query")
    +            .description("A custom SQL query used to retrieve data. 
Instead of building a SQL query from "
    +                    + "other properties, this query will be used. Query 
must have no WHERE or ORDER BY statements. "
    +                    + "If a WHERE clause is needed use a sub-query or the 
'Additional WHERE clause' property.")
    --- End diff --
    
    Do we need more doc here around max-value columns? If they specify a 
max-value column in the other property, and it is not available in this query, 
then the getSelectStatement() below doesn't seem like it would work as expected


---

Reply via email to