[
https://issues.apache.org/jira/browse/NIFI-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196189#comment-16196189
]
ASF GitHub Bot commented on NIFI-4367:
--------------------------------------
GitHub user frett27 opened a pull request:
https://github.com/apache/nifi/pull/2201
NIFI-4367 Fix on processor for permit deriving script classes from Ab…
…stractProcessor or other Records based base classes
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/frett27/nifi nifi-4367
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2201.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2201
----
commit 3eec6c7a022a2424accc5d84f425b8746719c2d0
Author: Patrice Freydiere <[email protected]>
Date: 2017-09-09T14:43:14Z
NIFI-4367 Fix on processor for permit deriving script classes from
AbstractProcessor or other Records based base classes
----
> InvokedScriptedProcessor
> ------------------------
>
> Key: NIFI-4367
> URL: https://issues.apache.org/jira/browse/NIFI-4367
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.3.0, 1.4.0
> Environment: Linux / Windows
> Reporter: Patrice Freydiere
> Labels: InvokeScriptedProcessor, validation
> Attachments:
> 0001-NIFI-4367-Fix-on-processor-for-permit-deriving-scrip.patch
>
>
> InvokeScriptedProcessor pass his ValidationContext to the inner script,
> validate call
> InvokeScriptedProcessor Line 465 : final
> Collection<ValidationResult> instanceResults = instance.validate(context);
>
> The problem is that the invokedscript pass the ScriptFile PropertyDescriptor
> that is validated, if the script derived from the
> AbstractConfigurableComponent, (because the AbstractConfigurableComponent
> validate all the context properties).
> The context should be refined to remove the InvokeScriptedProcessor
> Properties.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
