[
https://issues.apache.org/jira/browse/NIFI-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197572#comment-16197572
]
ASF GitHub Bot commented on NIFI-4386:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2203
NIFI-4386 Fixing connection handling in FetchFileTransfer
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-4386
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2203
----
commit 85c7159d4bd3ece99881ce3926f919d175664b44
Author: Bryan Bende <[email protected]>
Date: 2017-10-09T19:25:27Z
NIFI-4386 Fixing connection handling in FetchFileTransfer
----
> FetchSFTP - Ensure connection is closed
> ---------------------------------------
>
> Key: NIFI-4386
> URL: https://issues.apache.org/jira/browse/NIFI-4386
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Matt Gilman
> Assignee: Bryan Bende
> Priority: Critical
>
> If FetchSFTP fails due to permissions, it appears the connection is not being
> properly closed. The number of threads dedicated to SFTP sessions kept
> growing. The relevant part of the processor I believe is here [1]. We made
> need to investigate other failure scenarios as well.
> [1]
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FetchFileTransfer.java#L256-L262
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
