[
https://issues.apache.org/jira/browse/NIFI-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197638#comment-16197638
]
ASF GitHub Bot commented on NIFI-4476:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2204
NIFI-4476 Improving logic for determining when to yield in PutTCP/UDP…
…/Syslog/Splunk
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi yield-improvement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2204
----
commit 8d471983c2c0169b9541084ec7cb76b7bd9ebd25
Author: Bryan Bende <[email protected]>
Date: 2017-10-09T20:17:40Z
NIFI-4476 Improving logic for determining when to yield in
PutTCP/UDP/Syslog/Splunk
----
> PutTCP/UDP/Syslog/Splunk can unncessarily yield
> -----------------------------------------------
>
> Key: NIFI-4476
> URL: https://issues.apache.org/jira/browse/NIFI-4476
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Bryan Bende
> Assignee: Bryan Bende
>
> These processors all perform similar logic at the beginning of onTrigger...
> They attempt to get a flow file (syslog gets batches, others do single) and
> if no flow files are available they then attempt to close any connections
> that are considered idle, and then yield is called.
> All of these processors also have @TriggerWhenEmpty in order to give them a
> chance to close idle connections, so as a result we have to yield in order to
> not eat up the CPU.
> The problem is that in the current implementation, if there is a split second
> when no flow files are available, or if a failure queue is looped back to
> PutSyslog, then yield will be called, but we really didn't want to yield in
> those cases and now we slowed down the processor for no reason.
> We should only yield if we closed at least one connection which means data
> hasn't come through in greater than expiration time, or if there were already
> no connections which means we've closed them all and have been sitting in a
> loop yielding.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
