Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2132#discussion_r144078102
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java
---
@@ -508,7 +509,12 @@ private String generateInsert(final JsonNode rootNode,
final Map<String, String>
*
*/
protected static String createSqlStringValue(final JsonNode fieldNode,
final Integer colSize, final int sqlType) {
- String fieldValue = fieldNode.asText();
+ String fieldValue;
--- End diff --
Can you add unit test(s) to TestConvertJSONToSQL to cover this improvement?
The sample data in the Jira would make an excellent unit test :)
---
