Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/146#discussion_r144319079
  
    --- Diff: LICENSE ---
    @@ -564,4 +564,55 @@ ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, 
OUT OF OR IN
     CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
     SOFTWARE.
     ========================================================================
    +The libarchive distribution as a whole is Copyright by Tim Kientzle
    --- End diff --
    
    We need to be more detailed and specific in our LICENSE than this.  We will 
need to break out particular items and their terms for those efforts as there 
are several licenses and considerations at play for the various components of 
this library. 
    
    I would additionally recommend removing all extraneous parts of libarchive 
to reduce this footprint such as examples and test resources and those build 
scripts unneeded for our build.  


---

Reply via email to