Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2121#discussion_r145035152
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/AbstractSiteToSiteReportingTask.java
---
@@ -190,7 +191,7 @@ public void reportEvent(final Severity severity, final
String category, final St
context.getProperty(HTTP_PROXY_USERNAME).getValue(),
context.getProperty(HTTP_PROXY_PASSWORD).getValue());
siteToSiteClient = new SiteToSiteClient.Builder()
- .url(destinationUrl)
+
.urls(SiteToSiteRestApiClient.parseClusterUrls(destinationUrl))
--- End diff --
This change just reminded me that
`SiteToSiteRestApiClient.parseClusterUrls` also validates the destinationUrl.
Probably it'd be a better approach to use
`SiteToSiteRestApiClient.parseClusterUrls` and catch IllegalArgumentException
from `NiFiUrlValidator.validate()`, instead of implementing different
validation code there. How do you think?
---
