[
https://issues.apache.org/jira/browse/NIFI-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207070#comment-16207070
]
ASF GitHub Bot commented on NIFI-4343:
--------------------------------------
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2121#discussion_r145035152
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/AbstractSiteToSiteReportingTask.java
---
@@ -190,7 +191,7 @@ public void reportEvent(final Severity severity, final
String category, final St
context.getProperty(HTTP_PROXY_USERNAME).getValue(),
context.getProperty(HTTP_PROXY_PASSWORD).getValue());
siteToSiteClient = new SiteToSiteClient.Builder()
- .url(destinationUrl)
+
.urls(SiteToSiteRestApiClient.parseClusterUrls(destinationUrl))
--- End diff --
This change just reminded me that
`SiteToSiteRestApiClient.parseClusterUrls` also validates the destinationUrl.
Probably it'd be a better approach to use
`SiteToSiteRestApiClient.parseClusterUrls` and catch IllegalArgumentException
from `NiFiUrlValidator.validate()`, instead of implementing different
validation code there. How do you think?
> SiteToSite reporting tasks should support multi RPG urls
> --------------------------------------------------------
>
> Key: NIFI-4343
> URL: https://issues.apache.org/jira/browse/NIFI-4343
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Pierre Villard
> Assignee: Pierre Villard
> Priority: Minor
>
> With NIFI-3026 multiple URLs are allowed for the Site To Site initial
> connection. This should be reflected in Site To Site reporting tasks as well.
> Currently the property validator prevents the use of multiple URLs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
