[
https://issues.apache.org/jira/browse/NIFIREG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209952#comment-16209952
]
ASF GitHub Bot commented on NIFIREG-37:
---------------------------------------
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/24#discussion_r145529939
--- Diff:
nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/DatabaseMetadataService.java
---
@@ -353,7 +353,9 @@ public void deleteFlow(final FlowEntity flow) {
@Override
public FlowSnapshotEntity createFlowSnapshot(final FlowSnapshotEntity
flowSnapshot) {
- flowSnapshot.setCreated(new Date());
+ if (flowSnapshot.getCreated() == null) {
+ flowSnapshot.setCreated(new Date());
+ }
--- End diff --
@bbende, I know you are looking into a timestamp issue on NIFIREG-38
I added this because the time is also being set in the RegistryService on
initial creation (eg, the POST .../versions code path) and returned without
being updated by the data that was set here. So when the snapshot was fetched
later (eg, GET .../versions/latest) the timestamp assertions I added in FlowsIT
were failing.
If your pending solution for NIFIREG-38 makes this moot, I can drop this
change from this PR.
> Integration Test Framework for Registry Web API
> -----------------------------------------------
>
> Key: NIFIREG-37
> URL: https://issues.apache.org/jira/browse/NIFIREG-37
> Project: NiFi Registry
> Issue Type: Test
> Reporter: Kevin Doran
> Assignee: Kevin Doran
>
> Currently there are no automated integration tests for the web API
> application, making some complete features that touch multiple layers of the
> registry architecture difficult to test.
> The goal of this ticket is to introduce a framework for executing automated,
> integration test cases against the web API as part of the project build.
> Additionally, some initial test cases that exercise the core API feature set
> should be added to the framework.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
