[
https://issues.apache.org/jira/browse/MINIFICPP-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210270#comment-16210270
]
marco polo edited comment on MINIFICPP-261 at 10/18/17 11:22 PM:
-----------------------------------------------------------------
[~achristianson] Thanks for catching this. I wondered why mine worked and I
have the extensions copied in there so I must have copied it manually the last
time I ran make docker in that dir. Makes me wonder why we aren't running
docker builds in travis. That would help catch issues like that that in PRs. I
know docker can be run in builds. Any reason you wouldn't like to see that? I
only occasionally run make docker and would love to see that part of CI in a
pre commit target.
was (Author: phrocker):
[~achristianson] Thanks for catching this. I wondered why mine worked and I
have the extensions copied in there so either I copied it manually the last
time I ran make docker in that dir. Makes me wonder why we aren't running
docker builds in travis. That would help catch issues like that that in PRs. I
know docker can be run in builds. Any reason you wouldn't like to see that?
> Extensions not added to docker/minificppsource, causing make docker to fail
> ---------------------------------------------------------------------------
>
> Key: MINIFICPP-261
> URL: https://issues.apache.org/jira/browse/MINIFICPP-261
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
>
> We're not adding the extensions/ dir to docker/minificppsource/, which
> CMakeLists.txt references, so docker builds are failing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
