Benjamin Garrett created NIFI-4523:
--------------------------------------

             Summary: AWS S3 Processors should support arbitrary regions
                 Key: NIFI-4523
                 URL: https://issues.apache.org/jira/browse/NIFI-4523
             Project: Apache NiFi
          Issue Type: Improvement
          Components: Core Framework
    Affects Versions: 1.4.0
            Reporter: Benjamin Garrett
            Priority: Minor


Currently the ListS3 processor uses the REGION PropertyDescriptor defined in 
AbstractAWSProcessor.  This uses ".allowableValues()" which forces the region 
names to come from a hard coded list.  AWS does occasionally bring new regions 
online.  Every time there is a new region then we have to either wait for a new 
nifi upgrade or else override the AbstractAWSProcessor (as well as the 
necessary child classes which extend it). 

It is simple enough to just let us type in arbitrary text into the S3 
processor.  For example you could just comment out line 97 in 
AbstractAWSProcessor.

//.allowableValues(getAvailableRegions())

If you did this, typically you also have to add an appropriate validator, e.g.: 
 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)

A different approach would be to expand the Nifi framework to allow you to 
specify both ".allowableValues()" but also to allow someone to type in 
arbitrary text as well.  From a UI perspective, you would show the user a 
choice list but then also make it editable so someone can type in arbitrary 
text.  There have been other instances where I thought this feature would be 
useful.  Maybe you would use a different method name instead of 
allowableValues, such as 'possibleValues()', and if you did this then that 
would be an indicator that the user gets an editable choice list (as opposed to 
an uneditable hard-coded choice list).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to