Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146876835
  
    --- Diff: libminifi/src/processors/ExtractText.cpp ---
    @@ -0,0 +1,105 @@
    +/**
    + * @file ExtractText.cpp
    + * ExtractText class implementation
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#include <iterator>
    +#include <string>
    +#include <memory>
    +#include <set>
    +
    +#include "processors/ExtractText.h"
    +#include "core/ProcessContext.h"
    +#include "core/ProcessSession.h"
    +#include "core/FlowFile.h"
    +
    +namespace org {
    +namespace apache {
    +namespace nifi {
    +namespace minifi {
    +namespace processors {
    +
    +core::Property ExtractText::Attribute("Attribute", "Attribute to set from 
content (TEMPORARY)", "");
    --- End diff --
    
    @calebj @phrocker In the [reference NiFi 
ExtractText](https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-standard-nar/1.4.0/org.apache.nifi.processors.standard.ExtractText/index.html),
 the attribute to set from the extracted text, as well as the regular 
expression to match, is set with dynamic properties. Until MiNiFi - C++ 
supports dynamic properties, the intent was for ExtractText to support one 
regular expression and one attribute. The "TEMPORARY," if I recall correctly, 
was to document that this property is liable to be deprecated in the future. 
Looking back at it, we should probably clarify this, or remove the text 
altogether. Also suggest we prioritize the dynamic attributes feature.


---

Reply via email to