[
https://issues.apache.org/jira/browse/MINIFICPP-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221236#comment-16221236
]
ASF GitHub Bot commented on MINIFICPP-267:
------------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/155
MINIFICPP-267 Make inference of MINIFI_HOME more resilient, and grace…
…fully exit if home value is not valid.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-267
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit 688d9d438696d9b9af583bc9674d2f39deeec16d
Author: Andy I. Christianson <a...@andyic.org>
Date: 2017-10-26T21:05:18Z
MINIFICPP-267 Make inference of MINIFI_HOME more resilient, and gracefully
exit if home value is not valid.
----
> MiNiFiMain crashes and fails to infer MINIFI_HOME if MINIFI_HOME not set
> ------------------------------------------------------------------------
>
> Key: MINIFICPP-267
> URL: https://issues.apache.org/jira/browse/MINIFICPP-267
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Minor
>
> When launching minifi cmd direcly without setting MINIFI_HOME, minifi tries
> to infer MINIFI_HOME based on the exe path. This crashes the minifi (CentOS
> 7.4).
> {code}
> [main] [info] MINIFI_HOME was not found, determining based on executable path.
> terminate called after throwing an instance of 'std::logic_error'
> what(): basic_string::_S_construct null not valid
> Aborted (core dumped)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
