[ 
https://issues.apache.org/jira/browse/NIFI-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221863#comment-16221863
 ] 

ASF GitHub Bot commented on NIFI-4534:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2229#discussion_r147339002
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVReader.java
 ---
    @@ -60,6 +61,17 @@
         private volatile String timestampFormat;
         private volatile boolean firstLineIsHeader;
         private volatile boolean ignoreHeader;
    +    private volatile String charSet;
    +
    +    public static final PropertyDescriptor INPUT_CHARSET = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    Can we move this property into CSVUtils as the other properties? It seems 
to be more in line with the initial intent. Besides, you could use a single 
property for both reader and writer. Just need to have a more generic 
description like "The Character Encoding that is used to encode/decode the CSV 
file". What do you think?


> CSV Record Processors may have issues with UTF8
> -----------------------------------------------
>
>                 Key: NIFI-4534
>                 URL: https://issues.apache.org/jira/browse/NIFI-4534
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>            Priority: Minor
>
> In some circumstances (server specific?) CSVRecordReader/WriteCSVResult may 
> read UTF8 strings incorrectly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to