[ 
https://issues.apache.org/jira/browse/NIFI-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222938#comment-16222938
 ] 

ASF GitHub Bot commented on NIFI-4513:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2223#discussion_r147526938
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ---
    @@ -625,7 +629,7 @@ private void setAuthenticator(OkHttpClient.Builder 
okHttpClientBuilder, ProcessC
                 final DigestAuthenticator digestAuthenticator = new 
DigestAuthenticator(credentials);
     
                 if(!proxyUsername.isEmpty()) {
    -                final String proxyPassword = 
context.getProperty(PROP_PROXY_PASSWORD).getValue();
    +                final String proxyPassword = 
context.getProperty(PROP_PROXY_PASSWORD).evaluateAttributeExpressions().getValue();
    --- End diff --
    
    This precludes "plain-text" passwords with valid EL inside them, but I 
think it's getting more standard to support these, and eventually we will have 
encrypted variables, so I'm just mentioning it for posterity ;)


> Enable EL on proxy settings in InvokeHttp
> -----------------------------------------
>
>                 Key: NIFI-4513
>                 URL: https://issues.apache.org/jira/browse/NIFI-4513
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>
> It'd be useful to enable expression language on proxy settings in the 
> InvokeHttp processor. Using the variable registry it can be useful when 
> promoting templates from one environment to another.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to