[
https://issues.apache.org/jira/browse/NIFI-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225207#comment-16225207
]
ASF GitHub Bot commented on NIFI-4459:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2240
NIFI-4459: Catch Exception if trying to iterate over many confluent s…
…chemas and unable to load one; in this case log a WARNING and continue on;
also updated Jersey client to newest
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4459
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2240
----
commit 89c5a128c10e658d9bb95bc0c869d884bd4d202f
Author: Mark Payne <[email protected]>
Date: 2017-10-30T15:59:55Z
NIFI-4459: Catch Exception if trying to iterate over many confluent schemas
and unable to load one; in this case log a WARNING and continue on; also
updated Jersey client to newest
----
> Confluent Schema Registry - not tolerant to error in single Subject
> -------------------------------------------------------------------
>
> Key: NIFI-4459
> URL: https://issues.apache.org/jira/browse/NIFI-4459
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.4.0
> Reporter: Dave Torok
> Assignee: Mark Payne
> Priority: Minor
>
> Getting Could not find Schema with id 12345 from the Confluent Schema
> Registry.
> Root cause:
> 1. RestSchemaRegistryClient.java - gets all subjects from the registry
> {noformat}https://{registry}/subjects{noformat}
> 2. Iterates through the subjects to get schema IDs (getSchema method line
> 113-126)
> {noformat}https://{registry}/subjects/{subjectname}/ids/latest{noformat}
> 3. If ANY subject in the list of subjects has an error / resource not
> found, lookup FAILS, even if the subject with the matching ID is anywhere in
> the list of subjects.
> Proposed Fix:
> Tolerate individual subject calls that return errors (NOT_FOUND status).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
