Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147857772
  
    --- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
    @@ -0,0 +1,310 @@
    +/**
    --- End diff --
    
    General organizational note --it seems to be a bit of a mixing of concerns 
to have s2s-specific code under the http-curl extension.
    
    Granted, we probably have/will have dependencies between extensions which 
may or may not be easy to express using cmake constructs.


---

Reply via email to