[
https://issues.apache.org/jira/browse/NIFI-4543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226813#comment-16226813
]
ASF GitHub Bot commented on NIFI-4543:
--------------------------------------
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2237#discussion_r147998027
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java
---
@@ -196,4 +196,15 @@
*/
byte[] toBytesBinary(String s);
+ /**
+ * Create a transit URI from the current configuration and the
specified table name.
+ * The default implementation just prepend "hbase://" to the table
name and row key, i.e. "hbase://tableName/rowKey".
+ * @param tableName The name of a HBase table
+ * @param rowKey The target HBase row key, this can be null or empty
string if the operation is not targeted to a specific row
+ * @return a qualified transit URI which can identify a HBase table
row in a HBase cluster
+ */
+ default String toTransitUri(String tableName, String rowKey) {
+ return "hbase://" + tableName + (rowKey != null &&
!rowKey.isEmpty() ? "/" + rowKey : "");
--- End diff --
Are there any scenarios where `rowKey` will be null or empty?
> Improve HBase processors provenance transit URL
> -----------------------------------------------
>
> Key: NIFI-4543
> URL: https://issues.apache.org/jira/browse/NIFI-4543
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> HBase related processors report NiFi provenance events with transit URLs in a
> format as 'hbase://tablename/rowid'. However, the URL is not descriptive
> enough if a NiFi interacts with multiple HBase clusters having the same table
> names.
> HBase processors transit URL should include host information it operates
> with, so that an URL can identify a HBase cluster.
> Target Processors:
> * FetchHBaseRow
> * GetHBase
> * PutHBaseCell
> * PutHBaseJSON
> * PutHBaseRecord
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
