Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/162#discussion_r148027976
  
    --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
    @@ -118,14 +119,18 @@ void 
YamlConfiguration::parseProcessorNodeYaml(YAML::Node processorsNode, core::
             }
             processor->setName(procCfg.name);
     
    -        checkRequiredField(&procNode, "scheduling strategy",
    -        CONFIG_YAML_PROCESSORS_KEY);
    -        procCfg.schedulingStrategy = procNode["scheduling 
strategy"].as<std::string>();
    +        auto strategyNode = getOptionalField(&procNode,
    +                                             "scheduling strategy",
    +                                             YAML::Node("EVENT_DRIVEN"),
    --- End diff --
    
    Move the Yaml::Node(...), or the getOptionalField call? And where to?


---

Reply via email to