[
https://issues.apache.org/jira/browse/MINIFICPP-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227008#comment-16227008
]
ASF GitHub Bot commented on MINIFICPP-273:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/162#discussion_r148037953
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -118,14 +119,18 @@ void
YamlConfiguration::parseProcessorNodeYaml(YAML::Node processorsNode, core::
}
processor->setName(procCfg.name);
- checkRequiredField(&procNode, "scheduling strategy",
- CONFIG_YAML_PROCESSORS_KEY);
- procCfg.schedulingStrategy = procNode["scheduling
strategy"].as<std::string>();
+ auto strategyNode = getOptionalField(&procNode,
+ "scheduling strategy",
+ YAML::Node("EVENT_DRIVEN"),
--- End diff --
Sorry I meant the YAML::Node. I shouldn't have been so terse.
Here is a better way of putting it: Could we make it so that we centralized
the defaults in one place so in case of change it's easier to track down? I
know this isn't really the guise of the PR; however, it may improve the hygiene
of this class to do so or make a follow on ticket.
> Simplify configuration by supporting default values for scheduling strategy
> and period
> --------------------------------------------------------------------------------------
>
> Key: MINIFICPP-273
> URL: https://issues.apache.org/jira/browse/MINIFICPP-273
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Minor
>
> Simplify configuration of MiNiFi - C++ by allowing default values for
> scheduling strategy and period.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
