[
https://issues.apache.org/jira/browse/NIFI-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234002#comment-16234002
]
ASF GitHub Bot commented on NIFI-4490:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2244
NIFI-4490: Ensure driver settings are correct before connecting binlog
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4490
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2244
----
commit 6c929c9b56fd9c7821d7258d8de3da2495bdc11b
Author: Koji Kawamura <[email protected]>
Date: 2017-11-01T12:28:04Z
NIFI-4490: Ensure driver settings are correct before connecting binlog
----
> Repetitive events detected on changing the incorrect driver name in
> CaptureChangeMySQL
> --------------------------------------------------------------------------------------
>
> Key: NIFI-4490
> URL: https://issues.apache.org/jira/browse/NIFI-4490
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Matt Burgess
> Assignee: Koji Kawamura
> Priority: Major
>
> Followed the below steps
> 1. In CaptureChangeMySQL, set the driver name to "com.mysql.some.driver"
> 2. Create a table in the test database and start the CaptureChangeMySQL
> processor
> 3. "Error creating binlog enrichment JDBC connection" error message is thrown
> which is correct.
> This completes the first test. Next do the following
> 1. Correct the driver name
> 2. Reset the binlog events by running "RESET MASTER"
> 3. Clear the state of the CaptureChangeMySQL processor.
> 4. Start the CaptureChangeMySQL processor.
> Result : The Create statement which was triggered when the driver was invalid
> is detected thrice in the tests that I carried out by CaptureChangeMySQL
> processor
> Expected : The event should not have been detected at all since the binlogs
> have been deleted, state reset and the database pattern hardcoded to a single
> db
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
