[ 
https://issues.apache.org/jira/browse/MINIFICPP-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235772#comment-16235772
 ] 

ASF GitHub Bot commented on MINIFICPP-269:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r148539751
  
    --- Diff: extensions/bustache/TemplateLoader.h ---
    @@ -0,0 +1,68 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#ifndef EXTENSION_TEMPLATELOADER_H
    +#define EXTENSION_TEMPLATELOADER_H
    +
    +#include "ApplyTemplate.h"
    +#include "core/ClassLoader.h"
    +
    +class __attribute__((visibility("default"))) TemplateFactory : public 
core::ObjectFactory {
    + public:
    +  TemplateFactory() {
    +
    +  }
    +
    +  /**
    +   * Gets the name of the object.
    +   * @return class name of processor
    +   */
    +  virtual std::string getName() {
    +    return "TemplateFactory";
    +  }
    +
    +  virtual std::string getClassName() {
    +    return "TemplateFactory";
    +  }
    +  /**
    +   * Gets the class name for the object
    +   * @return class name for the processor.
    +   */
    +  virtual std::vector<std::string> getClassNames() {
    +    std::vector<std::string> class_names;
    +    class_names.push_back("ApplyTemplate");
    +    return class_names;
    +  }
    +
    +  virtual std::unique_ptr<ObjectFactory> assign(const std::string 
&class_name) {
    +    std::string name = class_name;
    --- End diff --
    
    seems like dead code here. 


> Implement ApplyTemplate processor
> ---------------------------------
>
>                 Key: MINIFICPP-269
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-269
>             Project: NiFi MiNiFi C++
>          Issue Type: New Feature
>            Reporter: Caleb Johnson
>            Priority: Minor
>              Labels: mustache, processor, template, templates
>
> The ApplyTemplate processor is fairly straightforward: it reads a 
> [mustache|https://mustache.github.io/] template from a provided path on disk 
> and maps flowfile attributes to template values.
> Dynamic properties (MINIFI-171) would go a long way towards making these 
> templates more flexible by using the union of input flowfile attributes and 
> (possibly evaluated?) properties as the value map.
> Due to its dependency on [bustache|https://github.com/jamboree/bustache] and 
> boost, it has been made into an optional extension, much like the libarchive 
> processors have.
> It may also be desirable to load the template from the input flowfile's 
> contents instead of a configurable path.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to