[
https://issues.apache.org/jira/browse/MINIFICPP-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237737#comment-16237737
]
ASF GitHub Bot commented on MINIFICPP-284:
------------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/173
MINIFICPP-284 Handle processor configuration errors better
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-284
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit 563afa1b367db20c4fc1d218a1a7da2cb074f79c
Author: Andy I. Christianson <[email protected]>
Date: 2017-11-03T15:20:29Z
MINIFICPP-284 Handle processor configuration errors better
----
> MiNiFi crashes if invalid processor is specified
> ------------------------------------------------
>
> Key: MINIFICPP-284
> URL: https://issues.apache.org/jira/browse/MINIFICPP-284
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> If an invalid processor is specified in the yml, MiNiFi identifies this, but
> it ends up with a segmentation fault.
> {code}
> [2017-11-03 11:11:40.653] [org::apache::nifi::minifi::FlowController] [info]
> Load Flow Controller from file
> /home/achristianson/workspace/minifi-flow-2017-10-25/conf/config.yml
> [New Thread 0x7fffdeffd700 (LWP 25910)]
> [New Thread 0x7fffde7fc700 (LWP 25911)]
> [New Thread 0x7fffddffb700 (LWP 25912)]
> [New Thread 0x7fffdd7fa700 (LWP 25913)]
> [New Thread 0x7fffdcff9700 (LWP 25914)]
> [2017-11-03 11:11:40.654] [org::apache::nifi::minifi::core::ProcessGroup]
> [info] ProcessGroup MiNiFi Flow created
> [2017-11-03 11:11:40.654]
> [org::apache::nifi::minifi::core::FlowConfiguration] [error] No Processor
> defined for UnkonwnProcesor
> [New Thread 0x7fffd7fff700 (LWP 25916)]
> [New Thread 0x7fffd77fe700 (LWP 25917)]
> [New Thread 0x7fffd6ffd700 (LWP 25915)]
> [New Thread 0x7fffd67fc700 (LWP 25920)]
> [New Thread 0x7fffd57fa700 (LWP 25919)]
> [New Thread 0x7fffd5ffb700 (LWP 25921)]
> [New Thread 0x7fffd4ff9700 (LWP 25918)]
> Thread 1 "minifi" received signal SIGSEGV, Segmentation fault.
> 0x000000000068ecde in
> org::apache::nifi::minifi::core::FlowConfiguration::createProcessor(std::string,
> unsigned char*) ()
> Missing separate debuginfos, use: debuginfo-install
> boost-filesystem-1.53.0-27.el7.x86_64 boost-system-1.53.0-27.el7.x86_64
> bzip2-libs-1.0.6-13.el7.x86_64 cyrus-sasl-lib-2.1.26-21.el7.x86_64
> elfutils-libelf-0.168-8.el7.x86_64 elfutils-libs-0.168-8.el7.x86_64
> keyutils-libs-1.5.8-3.el7.x86_64 krb5-libs-1.15.1-8.el7.x86_64
> libacl-2.2.51-12.el7.x86_64 libarchive-3.1.2-10.el7_2.x86_64
> libattr-2.4.46-12.el7.x86_64 libcap-2.22-9.el7.x86_64
> libcom_err-1.42.9-10.el7.x86_64 libcurl-7.29.0-42.el7.x86_64
> libgcc-4.8.5-16.el7.x86_64 libidn-1.28-4.el7.x86_64
> libpng-1.5.13-7.el7_2.x86_64 libselinux-2.5-11.el7.x86_64
> libssh2-1.4.3-10.el7_2.1.x86_64 libstdc++-4.8.5-16.el7.x86_64
> libusbx-1.0.20-1.el7.x86_64 libuuid-2.23.2-43.el7.x86_64
> libxml2-2.9.1-6.el7_2.3.x86_64 lua-5.1.4-15.el7.x86_64 lzo-2.06-8.el7.x86_64
> nspr-4.13.1-1.0.el7_3.x86_64 nss-3.28.4-12.el7_4.x86_64
> nss-softokn-freebl-3.28.3-8.el7_4.x86_64 nss-util-3.28.4-3.el7.x86_64
> openldap-2.4.44-5.el7.x86_64 openssl-libs-1.0.2k-8.el7.x86_64
> pcre-8.32-17.el7.x86_64 python-libs-2.7.5-58.el7.x86_64
> systemd-libs-219-42.el7_4.1.x86_64 xz-libs-5.2.2-1.el7.x86_64
> zlib-1.2.7-17.el7.x86_64
> (gdb) bt
> #0 0x000000000068ecde in
> org::apache::nifi::minifi::core::FlowConfiguration::createProcessor(std::string,
> unsigned char*) ()
> #1 0x00000000006b1e80 in
> org::apache::nifi::minifi::core::YamlConfiguration::parseProcessorNodeYaml(YAML::Node,
> org::apache::nifi::minifi::core::ProcessGroup*) ()
> #2 0x0000000000688add in
> org::apache::nifi::minifi::core::YamlConfiguration::getRoot(YAML::Node*) ()
> #3 0x0000000000688e65 in
> org::apache::nifi::minifi::core::YamlConfiguration::getRoot(std::string
> const&) ()
> #4 0x00000000006cc145 in org::apache::nifi::minifi::FlowController::load() ()
> #5 0x0000000000563fac in main ()
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
